fix(sdk-crashes): Ignore SentrySwizzleWrapper false positives (#105625) #105705
+344
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Author
|
@philipphofmann I’ve opened this PR and would appreciate a review when you have a chance. Thanks! |
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks a lot for tackling this @calm329. I added a few comments.
tests/sentry/utils/sdk_crashes/test_sdk_crash_detection_cocoa.py
Outdated
Show resolved
Hide resolved
Author
|
@philipphofmann I've fixed according to your feedback, could you review it again? |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks for including the feedback. We're not far away from an approval, @calm329 💯
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
philipphofmann
added
the
Trigger: getsentry tests
Member
|
@calm329, I went ahead and addressed https://github.com/getsentry/sentry/pull/105705/changes#r2682659766 with a few commits. Otherwise, we most likely would go back and forth a few times. I hope that's OK for you. When the tests are green, I will give this a final pass and approve. |
github-actions
bot
removed
the
Trigger: getsentry tests
philipphofmann
added
the
Trigger: getsentry tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105625
Summary
The SDK crash detection was incorrectly reporting crashes as SDK crashes when
SentrySwizzleWrapperwas the only SDK frame in the stacktrace. These are false positives becauseSentrySwizzleWrapperis an instrumentation frame that intercepts UI events but doesn't cause crashes itself.This PR adds a new conditional SDK frame detection mechanism that only ignores
SentrySwizzleWrapperwhen there are no other SDK frames above it (closer to the crash origin).Changes
sdk_crash_ignore_when_only_sdk_frame_matchersfield toSDKCrashDetectionConfigis_sdk_crash()inSDKCrashDetectorto handle conditional SDK framesSentrySwizzleWrapperpattern to Cocoa SDK configurationCocoaSDKSwizzleWrapperTestMixinwith 3 test cases:How it works
When iterating through frames (youngest to oldest):
True(SDK crash)False(not SDK crash, since any SDK frames above would have triggered step 1)FalseLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=148254234